Deprecate is_FreeAlgebraQuotientElement, ...#38184
Merged
vbraun merged 7 commits intosagemath:developfrom Jun 22, 2024
Merged
Conversation
added 3 commits
June 10, 2024 00:17
…nt|DualAbelianGroupElement|PermutationGroupElement|ChainComplexHomspace|DirichletCharacter|ModularFormElement|ModularSymbolsElement|ManinSymbol|FreeModuleElement|FreeAbelianMonoidElement|FreeMonoidElement|LinearConstraint|LinearTensor|LinearTensorConstraint|Graphics|DiscreteProbabilitySpace|DiscreteRandomVariable';SUFFIX=" "CLASS='ProbabilitySpace|RandomVariable';SUFFIX=_generic"; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
…ger grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
|
Documentation preview for this PR (built with commit 6c7dabc; changes) is ready! 🎉 |
Contributor
Author
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38184: Deprecate `is_FreeAlgebraQuotientElement`, ... <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38184 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38184: Deprecate `is_FreeAlgebraQuotientElement`, ... <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38184 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
This was referenced Jan 3, 2026
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 4, 2026
sagemathgh-41380: remove deprecated functions in algebras/ after sagemath#37896 ; Closed Date: 2024-05-12 sagemath#38184 ; Closed Date: 2024-06-22 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41380 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 4, 2026
sagemathgh-41384: remove deprecated stuff in homology after sagemath#38103 and sagemath#38184 both closed in 2024 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41384 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 6, 2026
sagemathgh-41380: remove deprecated functions in algebras/ after sagemath#37896 ; Closed Date: 2024-05-12 sagemath#38184 ; Closed Date: 2024-06-22 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41380 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 6, 2026
sagemathgh-41384: remove deprecated stuff in homology after sagemath#38103 and sagemath#38184 both closed in 2024 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41384 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
This was referenced Jan 12, 2026
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 13, 2026
sagemathgh-41393: remove deprecated stuff in monoids/ after sagemath#38280 ; Closed Date: 2024-07-24 sagemath#37897 ; Closed Date: 2024-05-12 sagemath#38184 ; Closed Date: 2024-06-22 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41393 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 14, 2026
sagemathgh-41393: remove deprecated stuff in monoids/ after sagemath#38280 ; Closed Date: 2024-07-24 sagemath#37897 ; Closed Date: 2024-05-12 sagemath#38184 ; Closed Date: 2024-06-22 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41393 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 14, 2026
sagemathgh-41436: remove some deprecated stuff in categories/ after sagemath#38184 ; Closed Date: 2024-06-22 sagemath#36396 ; Closed Date: 2024-02-02 sagemath#37922 ; Closed Date: 2024-05-25 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41436 Reported by: Frédéric Chapoton Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 14, 2026
sagemathgh-41437: remove some deprecated stuff in groups/ after sagemath#38184 ; Closed Date: 2024-06-22 sagemath#38103 ; Closed Date: 2024-06-09 sagemath#37449 ; Closed Date: 2024-03-31 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41437 Reported by: Frédéric Chapoton Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 31, 2026
sagemathgh-41542: Deprec after 38184 clean after sagemath#38184, closed in 2024 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41542 Reported by: Frédéric Chapoton Reviewer(s):
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 5, 2026
sagemathgh-41578: remove all deprecated stuff in modular again after sagemath#38184 ; Closed Date: 2024-06-22 sagemath#37090 ; Closed Date: 2024-03-31 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41578 Reported by: Frédéric Chapoton Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2026
sagemathgh-41578: remove all deprecated stuff in modular again after sagemath#38184 ; Closed Date: 2024-06-22 sagemath#37090 ; Closed Date: 2024-03-31 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41578 Reported by: Frédéric Chapoton Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 10, 2026
sagemathgh-41578: remove all deprecated stuff in modular again after sagemath#38184 ; Closed Date: 2024-06-22 sagemath#37090 ; Closed Date: 2024-03-31 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41578 Reported by: Frédéric Chapoton Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies